Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nobids/unify error handling in dashboard go #2580

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

D13ce
Copy link
Contributor

@D13ce D13ce commented Sep 28, 2023

This PR improves and unifies the error handling within Dashboard.go.

@D13ce D13ce requested a review from Eisei24 September 28, 2023 07:07
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, this file should not be here too. It belongs to #2579.

Copy link
Collaborator

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@D13ce D13ce merged commit 3a9e34e into master Oct 2, 2023
3 checks passed
@D13ce D13ce deleted the NOBIDS/UnifyErrorHandlingInDashboardGo branch October 2, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants